andygrove commented on PR #5292: URL: https://github.com/apache/datafusion-comet/pull/5292#issuecomment-6397299174
Thanks @peterxcli. The branch conflicts with main again in `CometCodegenSuite.scala` and `UtilsSuite.scala`. Could you rebase? Once you push, I'll apply the `run-spark-4.1-tests` and `run-all-spark-profiles` labels so the interval hash and `make_interval` changes get a verdict before auto-merge fires. Could you also rerun `CometDatetimeExpressionBenchmark` at the new head and update the numbers in the description? The ones there are from `72997e9`, before the writer and eager-argument changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
