comphead commented on code in PR #7217:
URL: https://github.com/apache/datafusion-comet/pull/7217#discussion_r4379730333
##########
native/spark-expr/src/conversion_funcs/numeric.rs:
##########
@@ -2945,6 +2953,37 @@ mod tests {
}
}
+ #[test]
+ fn test_cast_float_to_timestamp_legacy_saturates() {
Review Comment:
This test repeats `cast_float_to_timestamp.sql`. The fixture reads the same
values (`1e16`, `-1e16`, `9.3e12`, the double and float maxima, NaN) from
Parquet `double` and `float` columns and checks both `cast` and `try_cast`
against Spark, while this test checks hand-written expectations for the same
cases. Could it be dropped in favor of the fixture?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
