namanjain24-sudo commented on PR #25527: URL: https://github.com/apache/datafusion/pull/25527#issuecomment-6421619103
Thanks for checking both — that settles it. Moved the producer over to `SwitchExpression`. The map is now `match` on the index column with one literal arm per grouping set, so it names no function and `SELECT a, b FROM t GROUP BY GROUPING SETS ((a), (b))` exports with zero extension declarations again. The consumer reads a switch back as a `CASE` over a base expression, which replaces the `not_impl` that was there. There is a producer-side test asserting the declarations are empty, separate from the round trip, since that is the part another consumer has to resolve. Both findings are covered now — the old-plan test and upgrade-guide note in the previous commit, this in `86c53ac0d83`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
