alamb commented on code in PR #12384:
URL: https://github.com/apache/datafusion/pull/12384#discussion_r1749251672
##########
datafusion/sqllogictest/bin/sqllogictests.rs:
##########
@@ -30,11 +30,9 @@ use datafusion_common_runtime::SpawnedTask;
const TEST_DIRECTORY: &str = "test_files/";
const PG_COMPAT_FILE_PREFIX: &str = "pg_compat_";
-const STACK_SIZE: usize = 2 * 1024 * 1024 + 512 * 1024; // 2.5 MBs, the
default 2 MBs is currently too small
Review Comment:
❤️
##########
datafusion/sql/src/expr/mod.rs:
##########
@@ -174,6 +174,10 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
schema: &DFSchema,
planner_context: &mut PlannerContext,
) -> Result<Expr> {
+ // NOTE: This function is called recusively, so each match arm body
should be as
+ // small as possible to avoid stack overflows in debug builds.
Follow the
+ // common pattern of extracting into a separate function for
non-trivial
+ // arms.
Review Comment:
```suggestion
// arms.
//
// See https://github.com/apache/datafusion/pull/12384 for more
context
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
