comphead commented on code in PR #12384:
URL: https://github.com/apache/datafusion/pull/12384#discussion_r1749388513
##########
datafusion/sql/src/expr/mod.rs:
##########
@@ -174,6 +174,10 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
schema: &DFSchema,
planner_context: &mut PlannerContext,
) -> Result<Expr> {
+ // NOTE: This function is called recusively, so each match arm body
should be as
+ // small as possible to avoid stack overflows in debug builds.
Follow the
Review Comment:
oh did it happen for debug builds only?
please clarify what do you mean `small as possible`, small in terms of code,
or small in terms of bytes which allocated for the stackframe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
