ErikBPF commented on PR #6897: URL: https://github.com/apache/datafusion-comet/pull/6897#issuecomment-6428342227
Validated on Apollo against current `main` (`c4a0b1f2b`) at head `5ef93bc78`: - `spark-submit --master local[2] test_tpcbench.py` on Spark 4.1.3 and on Spark 3.5.2, the benchmark image default: "TPC-DS registration checks passed", exit 0 on both. - `py_compile` and `dev/ci/check-benchmark-runner.py`: passed. No CI job currently runs `benchmarks/tpc`, so this regression remains manual evidence. Should we wire a job or add `run-benchmark-check`, or is manual evidence acceptable here? The PR also has no closing issue; `#6418` is the performance investigation rather than this CHAR registration bug — is a separate issue required before undrafting? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
