matthewmturner commented on issue #4649: URL: https://github.com/apache/datafusion/issues/4649#issuecomment-6443508108
I tried to reproduce this like so but was not able to. i dont think any tests were ever added for this - do we think adding some SLT tests for example [here](https://github.com/apache/datafusion/blob/main/datafusion/sqllogictest/test_files/dictionary.slt) with these cases would be helpful to ensure no regressions and proper integration with arrow kernel? ```❯ datafusion-cli DataFusion CLI v55.1.0 > CREATE TABLE t AS SELECT arrow_cast(v, 'Dictionary(Int32, Utf8)') AS d FROM (VALUES ('b'), (NULL), ('a'), ('c'), (NULL)) AS x(v); 0 row(s) fetched. Elapsed 0.011 seconds. > SELECT arrow_typeof(d) FROM t LIMIT 1; +-------------------------+ | arrow_typeof(t.d) | +-------------------------+ | Dictionary(Int32, Utf8) | +-------------------------+ 1 row(s) fetched. Elapsed 0.033 seconds. > SELECT d FROM t ORDER BY d ASC NULLS FIRST; +------+ | d | +------+ | NULL | | NULL | | a | | b | | c | +------+ 5 row(s) fetched. Elapsed 0.016 seconds. > SELECT d FROM t ORDER BY d ASC NULLS LAST; +------+ | d | +------+ | a | | b | | c | | NULL | | NULL | +------+ 5 row(s) fetched. Elapsed 0.001 seconds. > SELECT d FROM t ORDER BY d DESC NULLS FIRST; +------+ | d | +------+ | NULL | | NULL | | c | | b | | a | +------+ 5 row(s) fetched. Elapsed 0.001 seconds. > SELECT d FROM t ORDER BY d DESC NULLS LAST; +------+ | d | +------+ | c | | b | | a | | NULL | | NULL | +------+ 5 row(s) fetched. Elapsed 0.001 seconds. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
