sabir-akhadov-localstack commented on code in PR #2712:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2712#discussion_r4391619019
##########
src/parser/mod.rs:
##########
@@ -8132,7 +8134,7 @@ impl<'a> Parser<'a> {
};
} else {
return self.expected_ref(
- "COLLATION, CONNECTOR, DATABASE, EXTENSION, FUNCTION, INDEX,
OPERATOR, POLICY, PROCEDURE, ROLE, SCHEMA, SECRET, SEQUENCE, STAGE, TABLE,
TRIGGER, TYPE, VIEW, MATERIALIZED VIEW, USER or WAREHOUSE after DROP",
+ "COLLATION, CONNECTOR, DATABASE, EXTENSION, FUNCTION, GROUP,
INDEX, OPERATOR, POLICY, PROCEDURE, ROLE, SCHEMA, SECRET, SEQUENCE, STAGE,
TABLE, TRIGGER, TYPE, VIEW, MATERIALIZED VIEW, USER or WAREHOUSE after DROP",
Review Comment:
Non-blocking: on dialects without `supports_drop_group` this now reads
`Expected: ... GROUP, ... after DROP, found: GROUP` (the gated test asserts
exactly that). Listing GROUP only when the dialect supports it would avoid the
contradiction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
