alamb commented on issue #8932: URL: https://github.com/apache/datafusion/issues/8932#issuecomment-2338079278
> Hi, I'm new to this project and was poking through the issues, can I try working this one out? > > It looks like, to remove the hash we would need to first compare by enum variant (it looks like based on the test that the declaration order determines the Ord). I see two solutions for this, either implementing a "discriminant" function to determine the variant ordering, or by having a lot of match arms. > > In the case of equivalent variant, we can then compare by fields, looks like it should work for the majority of them. > > Is that the right track? I think so . I don't think the actual relative order of `Expr`s is important, only that it is consistent It might be worth figuring out how to break this work into some smaller PRs (rather than one large one) -- perhaps by implementing partial ord for sub fields / structs that are used in Expr before trying to do so for the whole thing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
