dwsmith1983 commented on PR #7256: URL: https://github.com/apache/datafusion-comet/pull/7256#issuecomment-6458601133
#6785 adds a sort to `WindowBuilder` for the case this PR leaves as is: when the window's input doesn't show every partition key as ordered, the window sorts it by the partition keys and then the order keys. Both PRs change the `try_new` calls in `window.rs`. Whichever lands second can apply `with_declared_order` first and run the check on its result, so a trusted input keeps the declaration and gets no sort, and the "no orders" half of `window_declares_input_order_on_a_scan` then expects a `SortExec` over the scan. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
