comphead commented on PR #7256: URL: https://github.com/apache/datafusion-comet/pull/7256#issuecomment-6536702262
Thanks @sunchao, all three are fixed in 136e5cf53f. Details are inline. @andygrove, this reverts the fallback from your point 2. sunchao showed that it returns wrong rows when the order really is false, since Spark's window trusts that order too. A window whose input order may be false fails natively with the ordering error again, as on `main`. #6785 covers that case: it keeps a nested loop join over an ordered streamed side in Spark (#6898), and it sorts a window's input natively when the partition keys' order is not declared. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
