viirya commented on code in PR #919:
URL: https://github.com/apache/datafusion-comet/pull/919#discussion_r1751022807
##########
spark/src/main/scala/org/apache/spark/sql/comet/CometMetricNode.scala:
##########
@@ -79,6 +79,15 @@ object CometMetricNode {
"total time (in ms) spent in this operator"))
}
+ /**
+ * SQL Metrics for Comet native ScanExec
+ */
+ def scanMetrics(sc: SparkContext): Map[String, SQLMetric] = {
+ Map(
+ "cast_time" ->
+ SQLMetrics.createNanoTimingMetric(sc, "Total time for casting arrays"))
Review Comment:
"arrays" in "casting arrays" may be confused with Spark array type and
considered as time spent on casting (Spark) "arrays".
Maybe "casting columns"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
