comphead commented on code in PR #919:
URL: https://github.com/apache/datafusion-comet/pull/919#discussion_r1751047489
##########
spark/src/main/scala/org/apache/spark/sql/comet/CometScanExec.scala:
##########
@@ -198,9 +198,12 @@ case class CometScanExec(
// Tracking scan time has overhead, we can't afford to do it for each row,
and can only do
// it for each batch.
if (supportsColumnar) {
- Some("scanTime" -> SQLMetrics.createNanoTimingMetric(sparkContext, "scan
time"))
+ Seq(
Review Comment:
should be it a Map instead of Seq?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
