alamb commented on code in PR #12417:
URL: https://github.com/apache/datafusion/pull/12417#discussion_r1754807824
##########
datafusion/core/src/datasource/listing/table.rs:
##########
@@ -1430,15 +1476,18 @@ mod tests {
table_prefix: &str,
target_partitions: usize,
output_partitioning: usize,
+ file_ext: Option<&str>,
) -> Result<()> {
let ctx = SessionContext::new();
register_test_store(&ctx, &files.iter().map(|f| (*f,
10)).collect::<Vec<_>>());
let format = AvroFormat {};
- let opt = ListingOptions::new(Arc::new(format))
- .with_file_extension("")
+ let mut opt = ListingOptions::new(Arc::new(format))
Review Comment:
Maybe we could make this a nicer API by adding `with_file_extension_opt` or
something so this code could be like:
```rust
let opt = ListingOptions::new(Arc::new(format))
.with_file_extension_opt(file_ext)
.with_target_partitions(target_partitions);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
