raghavyadav01 commented on PR #26640: URL: https://github.com/apache/datafusion/pull/26640#issuecomment-6528749580
Thanks @alamb. Pushed b1937e7c5: the doc comments now state one property (a node returns rows based only on whether its input has rows), and the unit tests that duplicated the SLT cases are gone. Replies inline. Checked against DuckDB 1.5.6: the shapes that still decorrelate return the same rows, and the HAVING shape from #26629 (and its NOT EXISTS form, now in `subquery.slt`) errors instead of returning wrong rows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
