adriangb commented on PR #26249: URL: https://github.com/apache/datafusion/pull/26249#issuecomment-6533980896
## Benchmark summary for `7c6a3f5f` (compared against merge-base `611311c`) This is a fresh run of every suite. It lists only queries that changed by more than 10%. Everything else was within ±10%, which I treat as noise. | Suite | Pushdown filters | Query | HEAD | PR | Change | |---|---|---|---|---|---| | tpch10 | default | — | | | no change >10% | | tpch10 | **off** | — | | | no change >10% | | tpch10 | on | Q2 | 107.46 ms | 92.52 ms | 1.16x faster | | tpch10 | on | Q3 | 308.31 ms | 242.11 ms | 1.27x faster | | tpch10 | on | Q4 | 297.67 ms | 206.97 ms | 1.44x faster | | tpch10 | on | Q5 | 439.05 ms | 312.88 ms | 1.40x faster | | tpch10 | on | Q7 | 442.02 ms | 345.36 ms | 1.28x faster | | tpch10 | on | Q10 | 374.52 ms | 320.44 ms | 1.17x faster | | tpch10 | on | Q12 | 303.00 ms | 251.53 ms | 1.20x faster | | tpch10 | on | Q13 | 401.97 ms | 340.31 ms | 1.18x faster | | tpch10 | on | Q16 | 88.62 ms | 73.69 ms | 1.20x faster | | tpch10 | on | Q17 | 491.60 ms | 296.74 ms | 1.66x faster | | tpch10 | on | Q18 | 1629.72 ms | 1330.86 ms | 1.22x faster | | tpch10 | on | Q20 | 279.70 ms | 231.31 ms | 1.21x faster | | tpch10 | on | Q21 | 1234.26 ms | 941.86 ms | 1.31x faster | | tpch10 | on | Q22 | 134.42 ms | 78.97 ms | 1.70x faster | | tpch (sf1) | default / off | — | | | no change >10% | | tpch (sf1) | on | Q12 | 40.35 ms | 34.35 ms | 1.17x faster | | tpch (sf1) | on | Q17 | 71.86 ms | 44.79 ms | 1.60x faster | | tpch (sf1) | on | Q18 | 141.28 ms | 111.12 ms | 1.27x faster | | tpcds | default (2 runs) | Q65 | ~130 ms | ~73 ms | 1.75–1.78x faster | | tpcds | default (1 of 2 runs) | Q46 | 12.63 ms | 11.35 ms | 1.11x faster | | tpcds | off | Q65 | 129.23 ms | 70.82 ms | 1.82x faster | | tpcds | on | Q17 / Q25 / Q29 / Q50 | | | 2.14x / 2.20x / 1.86x / 2.02x faster | | tpcds | on | Q18 / Q64 / Q65 / Q72 | | | 1.43x / 1.56x / 1.69x / 1.27x faster | | tpcds | on | Q75 / Q85 / Q95 | | | 1.17x / 1.40x / 1.33x faster | | clickbench_partitioned | default (1 of 2 runs) | Q35 | 296.48 ms | 330.52 ms | 1.11x slower | | clickbench_partitioned | default (1 of 2 runs) | Q39 | 139.09 ms | 155.91 ms | 1.12x slower | | clickbench_partitioned | on | Q37 | 35.47 ms | 39.34 ms | 1.11x slower | | clickbench_partitioned | off | Q38 | 39.32 ms | 43.60 ms | 1.11x slower | | prepared_hash_join | default | — | | | all within ±6% | | hash_join_semi_anti | default | — | | | all within ±5% | **Takeaways** - @devanbenz: with filter pushdown **off**, tpch10 shows no query changing by more than 10% in either direction. The earlier regression did not reproduce. - With pushdown **on**, tpch10 and tpcds both get much faster across the board, by up to about 2x. - The only slowdowns are on four clickbench queries, each about 1.11x. Each one showed up in only one of the runs, so I read them as noise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
