andygrove opened a new pull request, #7335:
URL: https://github.com/apache/datafusion-comet/pull/7335

   ## Which issue does this PR close?
   
   No issue. This is a test-only fix for a flaky assertion that failed CI on 
#7314.
   
   ## Rationale for this change
   
   The `CometParquetWriterSuite` test "an INSERT into a table of the V2 file 
source is written natively through Hadoop" writes two files from two concurrent 
tasks. It then asserts that the list of files closed equals the list of files 
created, in order. When the second task's file closes first, the test fails 
with the same two paths in swapped order, as it did in the Spark 4.0, JDK 21 
[scans] job on #7314.
   
   ## What changes are included in this PR?
   
   The assertion compares the closed and created files as sets, as the test "a 
file written in several chunks is closed once" already does for its 
multi-partition write. The other tests in the suite that compare these lists in 
order write a single file, so their order cannot vary.
   
   ## How are these changes tested?
   
   The test itself is the change. It compiles and passes formatting locally, 
and CI runs the suite.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to