andygrove commented on PR #6427: URL: https://github.com/apache/datafusion-comet/pull/6427#issuecomment-6535302285
@sunchao this is approved and CI is green, but I held it back from the merge queue because viirya's 10-21 review is still open. The asks are renaming the suite to `CometExpressionDisplaySuite` with matching workflow entries, asserting on the whole executed plan (formatted EXPLAIN and `SparkPlanInfo`), dropping the assertions that can't fail, and documenting the `PartitionFilters` case next to the alias limitation. Could you take a look when you get a chance? Once those are answered I'll queue it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
