jayzhan211 commented on PR #26757: URL: https://github.com/apache/datafusion/pull/26757#issuecomment-6539996086
I kept this as one PR with five commits, each reviewable on its own (see the table in the description). I'm also fine moving the first commit, one rule type per mode, into its own PR to keep each PR smaller. I went with one PR because: - The first commit only has a reason to exist because of the analyzer phase: the two modes of `OutputRequirements` and `FilterPushdown` end up in different phases. On its own it is an API break whose only benefit is clearer rule names in `EXPLAIN VERBOSE`. - If the two PRs land in different releases, the same downstream code breaks twice, once for the renamed constructors and once for the trait change. GitHub code search finds about 70 uses of `new_add_mode`, `new_remove_mode` and `new_post_optimization`. - The other commits can't land separately without leaving main broken in between: without the FFI commit, a join planned through a `ForeignSession` fails at execution, and without the final-check commit the planner's error no longer names the rule that broke the plan. If you'd rather review the first commit as a separate PR, let me know and I'll open it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
