sunchao commented on code in PR #7359:
URL: https://github.com/apache/datafusion-comet/pull/7359#discussion_r4433301852
##########
spark/src/test/scala/org/apache/comet/CometIcebergNativeSuite.scala:
##########
@@ -2241,6 +2241,47 @@ class CometIcebergNativeSuite
}
}
+ // No schema change, so the schema evolution fallback does not apply.
+ test("data file that omits an optional nested field stays native") {
+ assume(icebergAvailable, "Iceberg not available in classpath")
+
+ withHadoopCatalog("test_cat") {
+ withSQLConf(
+ CometConf.COMET_ENABLED.key -> "true",
+ CometConf.COMET_EXEC_ENABLED.key -> "true",
+ CometConf.COMET_ICEBERG_NATIVE_ENABLED.key -> "true") {
+ val table = "test_cat.db.omitted_nested"
+ spark.sql(s"""
+ CREATE TABLE $table (id INT, s STRUCT<a: INT, b: INT>, l
ARRAY<STRUCT<x: INT, y: INT>>)
+ USING iceberg
+ """)
+ withSQLConf(CometConf.COMET_ENABLED.key -> "false") {
+ spark.sql(s"""
+ INSERT INTO $table VALUES
+ (1, named_struct('a', 1, 'b', 10), array(named_struct('x', 1,
'y', 100)))
+ """)
+ // Set after the insert: accept-any-schema matches columns by name.
+ spark.sql(
+ s"ALTER TABLE $table SET TBLPROPERTIES
('write.spark.accept-any-schema' = 'true')")
+ // This file has no s.b and no l.element.y.
+ spark
+ .sql("""
+ SELECT 2 AS id, named_struct('a', 2) AS s,
array(named_struct('x', 20)) AS l
+ UNION ALL
+ SELECT 3, CAST(NULL AS STRUCT<a: INT>), CAST(NULL AS
ARRAY<STRUCT<x: INT>>)
+ """)
+ .writeTo(table)
+ .append()
Review Comment:
Could the test check that at least one appended Parquet file lacks both
`s.b` and the list element’s `y` leaf? If a writer upgrade materializes them as
all-null columns, both Spark comparisons and the native-plan assertion will
still pass, and the test will stop exercising #7033. This suite already reads
`file_path` from the Iceberg files table and opens its footer with
`ParquetFileReader`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
