rgbuilds commented on code in PR #26452:
URL: https://github.com/apache/datafusion/pull/26452#discussion_r4434220993
##########
datafusion/pruning/src/pruning_predicate.rs:
##########
@@ -1349,6 +1349,16 @@ fn verify_support_type_for_prune(from_type: &DataType,
to_type: &DataType) -> Re
}
_ => to_type,
};
+ // Casting a timestamp to a time-of-day wraps at midnight and does not
+ // preserve ordering across day boundaries. Casting timestamp min/max
+ // statistics could therefore produce invalid bounds and prune matches.
Review Comment:
Thanks @jayzhan211 for identifying the broader root cause. I’ll keep this PR
scoped to #26451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
