2010YOUY01 commented on code in PR #26242:
URL: https://github.com/apache/datafusion/pull/26242#discussion_r4434261710
##########
datafusion/core/tests/fuzz_cases/sort_query_fuzz.rs:
##########
@@ -217,18 +216,16 @@ impl SortQueryFuzzer {
let results = self
.test_gen
- .fuzzer_run(init_seed, query_seed, config_seed)
+ .fuzzer_run(init_seed, query_seed, config_seed,
config_i == 0)
.await?;
println!("\n"); // Separator between tested runs
if expected_results.is_none() {
expected_results = Some(results);
} else if let Some(ref expected) = expected_results {
- // `fuzzer_run` might append `LIMIT k` to either the
- // expected or actual query. The number of results is
- // checked inside `fuzzer_run()`. Here we only check
- // that the first k rows of each result are consistent.
- check_equality_of_batches(expected, &results).unwrap();
+ // Every projected column is an ORDER BY key, so tied
+ // rows have identical output and can be compared in
order.
+ assert_eq!(expected, &results);
Review Comment:
This line change causes false positives for this test, it's getting fixed in
- https://github.com/apache/datafusion/pull/26983
Just want to double check it's only for cleanup here, and there is no other
reason requires `assert_eq`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
