lakshaydevoo-arch opened a new pull request, #27008: URL: https://github.com/apache/datafusion/pull/27008
> [!IMPORTANT] > > **Fork CI setup:** For pull requests from a fork to `main`, enable workflows in your fork's **Actions** tab before you push. > See the [fork CI setup guide](https://datafusion.apache.org/contributor-guide/#pull-requests-from-forks). ## Which issue does this PR close? Part of #26848. Related to #26966. ## Rationale for this change This PR separates the additional dictionary hashing benchmarks from the optimization in #26966, as requested during review. Having the benchmarks in `main` first will allow the benchmark bot to compare the same workloads before and after the optimization. ## What changes are included in this PR? - Add Int32 dictionary hashing benchmarks with 50% and 97% null keys. - Cover both single-column and multi-column hashing. - Keep the existing 0% and 3% null-key benchmarks unchanged. - Reuse deterministic null-key generation for reproducible workloads. The benchmarks use 8,192 rows and the existing dictionary value pool. No hashing implementation changes are included. ## What is the testing strategy for this PR? The new benchmarks are registered in the existing `with_hashes` Criterion benchmark suite. The benchmark target was previously compiled successfully using: `cargo bench -p datafusion-common --bench with_hashes --no-run` The additional cases were also executed locally and by the benchmark bot as part of #26966. This PR adds benchmark coverage only. Performance comparisons will be made against these benchmarks once they are available in the baseline. ## Are there any user-facing changes? No. This PR only adds benchmarks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
