galaxytemple commented on code in PR #26719:
URL: https://github.com/apache/datafusion/pull/26719#discussion_r4445789501
##########
datafusion/physical-optimizer/src/ensure_requirements/enforce_sorting/replace_with_order_preserving_variants.rs:
##########
@@ -97,6 +98,7 @@ pub fn plan_with_order_preserving_variants(
sort_input.data = false;
return Ok(sort_input);
}
+ let child_fetch = fetch.filter(|_|
sort_input.plan.supports_limit_pushdown());
Review Comment:
Thanks @Kristofferjoha, I agree that this is a much cleaner approach, and
having the test cases for #26690 included here is great.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
