kosiew commented on code in PR #26971:
URL: https://github.com/apache/datafusion/pull/26971#discussion_r4451379361
##########
datafusion/physical-plan/src/union.rs:
##########
@@ -1783,9 +1785,9 @@ mod tests {
);
for batch in batches {
assert_eq!(
- batch.schema().fields(),
- expected_schema.fields(),
- "{nullability:?}"
+ batch.schema(),
Review Comment:
Optional follow-up: could we add a UNION case where inputs differ only in
schema metadata, with identical field attributes? This would exercise
plain-Column coercion and verify that every emitted batch carries the
independently expected merged schema. Existing projection tests cover metadata
overrides, so this is additional integration coverage rather than a blocker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
