kosiew commented on code in PR #26982: URL: https://github.com/apache/datafusion/pull/26982#discussion_r4451994895
########## datafusion/sqllogictest/test_files/cast.slt: ########## @@ -164,6 +164,22 @@ physical_plan 02)--SortExec: TopK(fetch=3), expr=[column1@0 ASC NULLS LAST], preserve_partitioning=[false] 03)----DataSourceExec: partitions=1, partition_sizes=[1] +# An integer read as a count of seconds keeps its order, so the outer sort is +# removed. +query TT +EXPLAIN SELECT arrow_cast(i, 'Timestamp(Second, None)') AS ts Review Comment: The EXPLAIN verifies that the outer sort disappears, but does not check the resulting row order. Could you also execute the query with `query P` (required for timestamp columns by `strict_column_validator`, without `rowsort` or `valuesort`) and assert `1970-01-01T00:00:01`, `1970-01-01T00:00:02`, and `1970-01-01T00:00:03` in that order? Please retain the EXPLAIN to cover both optimization and SQL-visible ordering. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
