jayzhan211 commented on code in PR #26264:
URL: https://github.com/apache/datafusion/pull/26264#discussion_r4455032218
##########
datafusion/physical-plan/src/sorts/streaming_merge.rs:
##########
@@ -171,6 +174,13 @@ impl<'a> StreamingMergeBuilder<'a> {
self
}
+ /// Seat spill runs beyond the minimum two only while the pool can admit
+ /// their buffers plus equal headroom. Release the headroom before merging.
Review Comment:
Optional cleanup: the headroom is only as much again as the merge takes
beyond its retained workspace, not the full buffers. The same wording is on the
field doc in `multi_level_merge.rs` around line 163.
```suggestion
/// Seat spill runs beyond the minimum two only while the pool can admit
/// their buffers plus as much again as they exceed the retained
workspace.
/// Release the headroom before merging.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
