MisterRaindrop commented on PR #26264:
URL: https://github.com/apache/datafusion/pull/26264#issuecomment-6675441272
Thanks both. Pushed c7c5b196b.
@jayzhan211 I reproduced your numbers. Headroom is now kept only when the
sort has sibling partitions or another consumer holds pool memory. Single
partition now spills the same rows as without headroom in all four of your
configs. With 4 partitions / 32 MB pool / 1 MB reservation, no headroom
fails 5/5 ("Not enough memory to continue external sort"); with it, 5/5
pass.
@kosiew Added both boundary tests, and applied the wording suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
