andygrove commented on PR #7053: URL: https://github.com/apache/datafusion-comet/pull/7053#issuecomment-6605978487
Pushed 9e402088f, which merges main and addresses the open threads. @viirya: the `LEGACY` write fallback is now in this PR, using `legacyDatetimeRebaseWriteReason` from #5048 unchanged. `EXCEPTION` stays with #7047, and the schema footer key stays with #7048, which already covers it. I added the `run-all-spark-profiles` label. @comphead: this PR owns the writer footer, so the field 10 collision goes away (`spark_version` is now field 11 because main took 10 for `jvm_output_stream`). #5048 can drop its writer changes, including the `NativeWriteUtils` helper and its two call sites, and keep the read-side parts. The helper text is identical, so dropping it should rebase cleanly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
