Rich-T-kid commented on code in PR #27025:
URL: https://github.com/apache/datafusion/pull/27025#discussion_r4455723004
##########
datafusion/common/src/hash_utils.rs:
##########
@@ -2284,6 +2368,78 @@ mod tests {
assert_eq!(result, expected_hashes);
}
+ #[test]
+ #[cfg(not(feature = "force_hash_collisions"))]
Review Comment:
Addressed in 0a7c4da0c with a brief comment: `PrimitiveArray::values()`
already accounts for slices, and every dictionary key width uses the same
generic `as_usize` lookup, so neither changes the fast-path invariant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
