alamb commented on issue #12363: URL: https://github.com/apache/datafusion/issues/12363#issuecomment-2346880610
I agree with @ncclementi -- the semantics of `TEMPORARY` tables are different than tables so silently ignoring the keyword is likely to be confusing (e.g. as they aren't distinguished in the information_schema). Btw I found a bunch of other syntax that is also ignored -- see https://github.com/apache/datafusion/pull/12450 If someone wants to implement `temporary` tables that sounds like a good idea to me -- I think that would mean propagating the `temporary` flag into the `CreateTable` statement and then into the table provider / info schema that would seem like a good change to me Hopefully I didn't get too excited merging PRs earlier today. We can back out https://github.com/apache/datafusion/pull/12439 if you prefer or think we should have some more discussion about it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
