comphead commented on code in PR #7484:
URL: https://github.com/apache/datafusion-comet/pull/7484#discussion_r4470290872
##########
spark/src/test/scala/org/apache/spark/sql/comet/ParquetEncryptionITCase.scala:
##########
@@ -37,12 +37,14 @@ import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.test.SQLTestUtils
import org.apache.comet.{CometConf, IntegrationTestSuite}
+import org.apache.comet.tags.ScansGroup
/**
* A integration test suite that tests parquet modular encryption usage.
*/
@RunWith(classOf[JUnitRunner])
@IntegrationTestSuite
+@ScansGroup
Review Comment:
This tag does not select this suite. It is excluded from the ScalaTest
plugin through `@IntegrationTestSuite` and runs under `maven-failsafe-plugin`
by its `*ITCase` name. CI uses `install`, so today it runs in every group's
job, and the `scans` list entry has no effect. `run-comet-tests.sh scans` with
the default `test` goal never reaches the failsafe phase, so it never runs this
suite. I have not run either. Could the script docs say so, and could #7483 run
failsafe for one group only?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
