andygrove commented on code in PR #7484:
URL: https://github.com/apache/datafusion-comet/pull/7484#discussion_r4481017720
##########
spark/src/test/scala/org/apache/spark/sql/comet/ParquetEncryptionITCase.scala:
##########
@@ -37,12 +37,14 @@ import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.test.SQLTestUtils
import org.apache.comet.{CometConf, IntegrationTestSuite}
+import org.apache.comet.tags.ScansGroup
/**
* A integration test suite that tests parquet modular encryption usage.
*/
@RunWith(classOf[JUnitRunner])
@IntegrationTestSuite
+@ScansGroup
Review Comment:
You're right, and the script and the development guide now say so
(432e0c7983, 53b705aadc). The ScalaTest plugin excludes
`@IntegrationTestSuite`, and failsafe ignores `-DtagsToInclude`.
`run-comet-tests.sh` with the default `test` goal never runs this suite, and
with `--goal install` it runs in every group. CI uses `install` and selects
suites by the workflow lists, so today the `scans` entry for it has no effect
either.
I kept the tag, since `check-suites.py` requires one on every concrete
suite. Making it mean something is a change to how CI runs failsafe, so it goes
in #7483: the script passes failsafe only the `*ITCase` suites that carry the
group's tag, or `-DskipITs` when there are none, so this suite runs in the
`scans` job only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
