vshalpnjabi opened a new pull request, #27100: URL: https://github.com/apache/datafusion/pull/27100
## Which issue does this PR close? - Closes #27096. ## Rationale for this change `UPDATE t SET a = 1, a = 2` planned successfully and applied only the last assignment. The SQL standard doesn't allow the same column twice in a SET list, and PostgreSQL and DuckDB reject it. A typo like `SET a = x, a = y` (meant `b = y`) would silently update the wrong data. ## What changes are included in this PR? `SqlToRel::update_to_plan` now inserts SET targets into the column map one at a time and returns a planning error on a repeat: `Error during planning: multiple assignments to same column "a"` `t.a` and `a` count as the same target, since the planner already keys SET columns by the last identifier. ## Are these changes tested? Yes: - `update_rejects_duplicate_assignment` in `datafusion/sql/tests/sql_integration.rs` (adjacent duplicates, a duplicate after another column, qualified + unqualified). It fails on `main` and passes with the fix. - `update.slt`: the issue's reproducer, plus a normal `SET a = 1, b = 2` that still updates. Ran locally: - `cargo test -p datafusion-sql` - `cargo test --profile=ci -p datafusion-sqllogictest --test sqllogictests -- update.slt` - `cargo clippy -p datafusion-sql --all-targets --all-features -- -D warnings` - `cargo fmt --all -- --check` ## Are there any user-facing changes? Yes. An `UPDATE` that assigns the same column more than once is now a planning error instead of keeping the last value. No public API changes. One assumption to flag: the check uses the same key the planner already used (`Ident.value`), so it doesn't add any identifier normalization. Quoted `"A"` vs unquoted `a` behave as they did before. AI-assisted; I reviewed the full diff and ran the tests myself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
