galaxytemple commented on PR #27060: URL: https://github.com/apache/datafusion/pull/27060#issuecomment-6616717691
While working on this, I also noticed that SPM without limit (at L589 `else if is_sort_preserving_merge(plan)`) has a similar issue. I couldn't find a query that actually reaches that branch, since without Limit and offset EliminateSort drops the child sort, and with offset, GlobalLimitExec block the pushdown earlier. But in case a query reaches there, pushing down without updating SPM's own merge keys would likely produce incorrect results.(similar to #26654, SPM only preserves its own merge keys across partitions). But since this is related to the performance issue #16217, I thought it's better to open a separate issue to discuss it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
