alamb commented on code in PR #27122:
URL: https://github.com/apache/datafusion/pull/27122#discussion_r4497686693
##########
datafusion/optimizer/src/simplify_expressions/inlist_simplifier.rs:
##########
@@ -32,15 +32,25 @@ impl<'a> ShortenInListSimplifier<'a> {
let Ok(data_type) = expr.get_type(self.schema) else {
return false;
};
- matches!(
- data_type,
- DataType::Int32
- | DataType::Int64
- | DataType::UInt64
- | DataType::Float32
- | DataType::Float64
- | DataType::FixedSizeBinary(1 | 2 | 4 | 8 | 16)
- ) && list.iter().all(|expr| expr.as_literal().is_some())
+ let is_float = matches!(data_type, DataType::Float32 |
DataType::Float64);
Review Comment:
I think this is treating the symptom rather than the problem ---
specifically that the short InList implementation uses bit equality for floats.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
