jayzhan211 commented on PR #26853: URL: https://github.com/apache/datafusion/pull/26853#issuecomment-6702758711
@alamb #26853 isn't the cause: the regression starts at #23528. Your agent did find the right place, but the `SortKeyWalk` change in #27140 can't ship alone. In 2,016 generated query runs it adds 110 new `SanityCheckPlan` failures, including the #26762 query with `k` removed from the SELECT lists. #27191 keeps that change, with you as the commit's author, and adds a small check in sort pushdown. Those runs then have 0 plan errors with unchanged rows, and the patch applies cleanly to `branch-56`. It also fixes a separate new `branch-56` failure from #26747. Could you review #27191 in place of #27140? Start with `handle_projection_pushdown`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
