lakshaydevoo-arch commented on code in PR #27008:
URL: https://github.com/apache/datafusion/pull/27008#discussion_r4502608511
##########
datafusion/common/benches/with_hashes.rs:
##########
@@ -159,6 +180,26 @@ fn criterion_benchmark(c: &mut Criterion) {
];
do_hash_test(b, &arrays);
});
+ for &null_percent in additional_null_densities {
+ let nullable_array = add_nulls(&array, null_percent as f32 /
100.0);
+ c.bench_function(
+ &format!("{name}: single, {null_percent}% nulls"),
+ |b| {
+ do_hash_test(b, std::slice::from_ref(&nullable_array));
+ },
+ );
+ c.bench_function(
+ &format!("{name}: multiple, {null_percent}% nulls"),
+ |b| {
+ let arrays = vec![
Review Comment:
the new 50% and 97% multi-column cases now use different deterministic
seeds for each column. i checked the null counts and mask differences as well.
i've kept the existing 3% cases unchanged so their benchmark inputs stay
comparable with main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
