Phoenix500526 commented on PR #27066: URL: https://github.com/apache/datafusion/pull/27066#issuecomment-6716220765
> [@Phoenix500526](https://github.com/Phoenix500526) thanks for applying the cleanup! It removed the last non-test caller of `JoinKeySet::is_empty` (`join_key_set.rs` around line 108), so `cargo clippy -p datafusion-optimizer --all-targets -- -D warnings` now fails with `` method `is_empty` is never used ``. That one's my miss, sorry. Fork CI skipped clippy, so it doesn't show up here. Adding `#[cfg(test)]`, as `len` already has, fixes it; clippy and the `join_key_set` tests pass with it: > > --- a/datafusion/optimizer/src/join_key_set.rs > +++ b/datafusion/optimizer/src/join_key_set.rs > @@ -105,6 +105,7 @@ impl JoinKeySet { > } > > /// returns true if this set is empty > + #[cfg(test)] > pub fn is_empty(&self) -> bool { > self.inner.is_empty() > } Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
