andygrove commented on PR #25853: URL: https://github.com/apache/datafusion/pull/25853#issuecomment-6723039337
Filed the remaining dictionary case (values that repeat within a group but not across groups, with a large dictionary) as #27240, with a reproducer. It fails the same way as before this PR's dictionary change did, so I'd keep it out of this PR and handle it as a follow-up, alongside the consolidation in #26711. @2010YOUY01 @jayzhan211 thanks for the design notes. This PR stays a bounded fix for #25851, and the design questions (one byte limit for every caller, removing the three workarounds) belong under #26711. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
