2010YOUY01 commented on PR #25853: URL: https://github.com/apache/datafusion/pull/25853#issuecomment-6700552632
> @alamb @2010YOUY01 do you have any additional feedback, or can we merge this one (and maybe consider for 56.0.0)? I don't fully understand the underlying logic, so I can't offer concrete feedback. Just sharing an additional perspective here. I have no objections and trust the reviewers' approval judgment. **Suggestion:** If anyone has a good understanding of the overall sort spilling design, it would be helpful to add a top-level comment summarizing how the existing mechanisms fit together. **Concern:** Given the PR history in fixing sort spilling, I have the impression that more fixes may actually introduce more bugs rather than make spilling more stable. The process feels a bit like gradient descent programming—fixing corner cases one by one, the review also focus on letting AI to identify more corner cases, rather than refining a clear high-level design. This makes it hard to tell whether we're converging toward a stable implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
