jayshrivastava commented on code in PR #26593:
URL: https://github.com/apache/datafusion/pull/26593#discussion_r4444596532
##########
datafusion/common/src/partitioning.rs:
##########
@@ -89,10 +86,10 @@ pub fn validate_range_split_points(
split_points[0].values(),
split_points[1].values(),
sort_options,
- )? != Ordering::Less
+ )? == Ordering::Greater
Review Comment:
The main reason is that padding empty partitions is supported
`Partitioning::Unknown`. For example, I I can add an empty file group. Doing
the same when a data source is `Partitioning::Range` introduces an error.
In distributed-datafusion, this feature ensure all tasks (horizontally
distributed parts of the plan) have the same number of partitions. This
simplifies the code a lot. I imagine the same is true for ballista etc but I'm
not 100% sure. We could move away from this if anyone feels strongly, but I
figured it's a pretty inoffensive change to make in this repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
