jayshrivastava commented on PR #26593: URL: https://github.com/apache/datafusion/pull/26593#issuecomment-6582609949
FAQ 1. Why make bounds optional instead of using `type::MIN` and `type::MAX` Some types don't have a max or a reasonable value ex. what's the max of a string? "zzzzzz"? 2. Why is this PR so large? Tests around range satisfaction. Generally, a join may join two different ranges, with or without bounds. 50% of this PR is just adding test coverage around that. For example, the join type influences the behavior here. Happy to delete tests if people thing any are less useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
