tlfua commented on issue #7245: URL: https://github.com/apache/datafusion-comet/issues/7245#issuecomment-6594459412
Hi @LinSimon-901101, I've taken this issue and I'm working on the kernel-side fix: making `read_side_padding` (`lpad`/`rpad`) accept a runtime scalar string argument, as suggested in @sunchao's [review on #5889](https://github.com/apache/datafusion-comet/pull/5889#discussion_r4321296723) and @andygrove's [split plan](https://github.com/apache/datafusion-comet/pull/5889#issuecomment-6425145597) (padding fix to land before the struct support). Since you mentioned moving the independent fixes out of #5889 into separate PRs, just want to make sure we don't duplicate work. Please let me know if you've already started on the padding part. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
