andygrove commented on issue #2893: URL: https://github.com/apache/datafusion-sqlparser-rs/issues/2893#issuecomment-6752394671
> > and slices/&str are not viable, possibly as I said before we can go for Cow + &str for the subset of dialects where no allocation-requiring syntax is needed > > I agree `Cow` is the way to go My proposed version just uses `&str` and it supports pretty much all the features, including serde (in both directions). It is possible to switch to `Cow` but that would add some overhead. What is the reason for wanting to avoid `&str`? I understand that it means the AST has to outlive the lifetime of the source. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
