andygrove commented on issue #2893: URL: https://github.com/apache/datafusion-sqlparser-rs/issues/2893#issuecomment-6754309721
> You mean downstream though, right? Here I am asking about corner cases in sqlparser specifically. In cases downstream where people want `String`, they can have it with the aforementioned solution. Yes, my experiment was to see what gaps there are when trying to make DataFusion use the proposed approach, and the `Cow` issue came up there. These are good enough example to prove that we can't use `&str`. I don't know what the corner cases are in sqlparser specifically, but I think this is moot at this point? The experiment also gives me plenty of other things to think about. It's sad to see my enthusiastic attempt at a rewrite crash into reality so quickly 😄. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
