alexanderbianchi commented on code in PR #26890:
URL: https://github.com/apache/datafusion/pull/26890#discussion_r4525491331
##########
datafusion/substrait/src/logical_plan/consumer/substrait_consumer.rs:
##########
@@ -211,82 +191,120 @@ pub trait SubstraitConsumer: Send + Sync + Sized {
/// All [Rel]s to be converted pass through this method.
/// You can provide your own implementation if you wish to customize the
conversion behaviour.
- async fn consume_rel(&self, rel: &Rel) ->
datafusion::common::Result<LogicalPlan> {
- from_substrait_rel(self, rel).await
+ async fn consume_rel(
+ &self,
+ rel: &Rel,
+ context: &SubstraitConsumerContext,
+ ) -> datafusion::common::Result<LogicalPlan> {
+ from_substrait_rel(self, rel, context).await
+ }
+
+ /// Consumes independent inputs of a JOIN or UNION, returning plans in
input order.
+ ///
+ /// Implementations must return exactly one plan per input, in the same
order.
+ /// On error, implementations must drop any unfinished input futures.
+ ///
+ /// The default consumes inputs sequentially, stopping at the first error.
+ /// Overrides can provide a different scheduling policy, but must account
for
+ /// any additional mutable traversal state in the custom consumer.
+ async fn consume_rel_inputs(
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
