mbutrovich commented on PR #27308: URL: https://github.com/apache/datafusion/pull/27308#issuecomment-6773630287
I don't think this can go to `branch-54` as written, because it is a breaking API change and a behavior change. `ExecutionOptions` is generated by `config_namespace!`, which emits a plain `pub struct` that is not `#[non_exhaustive]` ([config.rs#L133](https://github.com/apache/datafusion/blob/9e0a08fd8627e5423f2b09b0ca13a5015b7cadee/datafusion/common/src/config.rs#L133)). Adding the public `listing_table_hive_default_partition_name` field breaks any downstream code that builds it with a struct literal, which the PR description already notes. That is a "Major Changes" item in the Cargo SemVer rules the [API health policy](https://github.com/apache/datafusion/blob/9e0a08fd8627e5423f2b09b0ca13a5015b7cadee/docs/source/contributor-guide/api-health.md?plain=1#L19-L21) refers to, and the target here is `54.2.0`, a minor bump. The [release management policy](https://github.com/apache/datafusion/blob/9e0a08fd8627e5423f2b09b0ca13a5015b7cadee/docs/source/contributor-guide/release_management.md?plain=1#L59-L62) says patch releases carry fixes only, and lists new config options, new public APIs, and breaking API changes as [not recommended for backport](https://github.com/apache/datafusion/blob/9e0a08fd8627e5423f2b09b0ca13a5015b7cadee/docs/source/contributor-guide/release_management.md?plain=1#L79-L85). This PR adds the config option, the public `HIVE_DEFAULT_PARTITION_NAME` constant, and the field. It also changes behavior: all `ListingTable` partition fields become nullable, and partitioned writes now reject the marker string and NULL keys. The [policy](https://github.com/apache/datafusion/blob/9e0a08fd8627e5423f2b09b0ca13a5015b7cadee/docs/source/contributor-guide/release_management.md?plain=1#L92-L106) asks for a stated reason why such a change should ship in a patch release instead of the next major. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
