hareshkh commented on PR #27308: URL: https://github.com/apache/datafusion/pull/27308#issuecomment-6780022797
Sorry @mbutrovich, I was still iterating on this PR and should have opened it as a draft. Thanks for the prompt review. I’ve removed the execution option and public constant to avoid the `ExecutionOptions` compatibility break. The rationale for the cherry-pick is that Hive NULL partitions currently fail the query for types such as dates, integers on `branch-54` and they would now return NULL. However for string partitions, this technically changes behaviour - the literal `__HIVE_DEFAULT_PARTITION__` becomes NULL, but this is matching its intended meaning in Hive partitioning. Partition columns also become nullable, and the rejection of writing the reserved marker as a literal partition value remains. Defer to you on if this appropriate for branch-54. Could you please take another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
