parthchandra commented on code in PR #915:
URL: https://github.com/apache/datafusion-comet/pull/915#discussion_r1761594517
##########
spark/src/main/scala/org/apache/spark/sql/comet/CometScanExec.scala:
##########
@@ -141,8 +141,30 @@ case class CometScanExec(
if (wrapped == null) Map.empty else wrapped.metadata
override def verboseStringWithOperatorId(): String = {
- getTagValue(QueryPlan.OP_ID_TAG).foreach(id =>
wrapped.setTagValue(QueryPlan.OP_ID_TAG, id))
- wrapped.verboseStringWithOperatorId()
+ val metadataStr = metadata.toSeq.sorted
Review Comment:
I see, that makes sense.
On an unrelated note, wonder why `CometScanExec` extends
`DataSourceScanExec` instead of `FileSourceScanExec` (if it had we would have
got the verboseString for free)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
